Skip to content

Fix issue #196 #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2020
Merged

Fix issue #196 #198

merged 1 commit into from
Oct 19, 2020

Conversation

Mighty683
Copy link
Contributor

AuthorizationStatus in PushNotificationPermissions is actually a number value not whole interface. I made PushNotificationPermissions to include values from this interface

Naturalclar
Naturalclar approved these changes Oct 19, 2020
View reviewed changes
Copy link
Collaborator

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mighty683 thanks for catching this!

@Naturalclar Naturalclar merged commit 03dd2e9 into react-native-push-notification:master Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Naturalclar Naturalclar Naturalclar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mighty683 @Naturalclar